getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.08k stars 3.98k forks source link

chore(issues): post GA cleanup for GroupSnooze caches #69975

Closed vartec closed 2 weeks ago

vartec commented 2 weeks ago

Cleaning up https://github.com/getsentry/sentry/pull/69556 and https://github.com/getsentry/sentry/pull/69939

Also changing cached value to more meaningful names.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.82%. Comparing base (c2ba9cc) to head (c2a3bca). Report is 1 commits behind head on master.

:exclamation: Current head c2a3bca differs from pull request most recent head 28a5b2e. Consider uploading reports for the commit 28a5b2e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #69975 +/- ## ========================================== + Coverage 76.69% 79.82% +3.13% ========================================== Files 6498 6495 -3 Lines 289051 288921 -130 Branches 49776 49753 -23 ========================================== + Hits 221674 230638 +8964 + Misses 66978 57887 -9091 + Partials 399 396 -3 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/69975?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [src/sentry/conf/server.py](https://app.codecov.io/gh/getsentry/sentry/pull/69975?src=pr&el=tree&filepath=src%2Fsentry%2Fconf%2Fserver.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9jb25mL3NlcnZlci5weQ==) | `89.18% <ø> (ø)` | | | [src/sentry/features/temporary.py](https://app.codecov.io/gh/getsentry/sentry/pull/69975?src=pr&el=tree&filepath=src%2Fsentry%2Ffeatures%2Ftemporary.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9mZWF0dXJlcy90ZW1wb3JhcnkucHk=) | `100.00% <ø> (ø)` | | | [src/sentry/models/groupsnooze.py](https://app.codecov.io/gh/getsentry/sentry/pull/69975?src=pr&el=tree&filepath=src%2Fsentry%2Fmodels%2Fgroupsnooze.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9tb2RlbHMvZ3JvdXBzbm9vemUucHk=) | `100.00% <100.00%> (ø)` | | ... and [668 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/69975/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)
sentry-io[bot] commented 2 weeks ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎