fix(replay): Handle invalid canvas id uniformly

getsentry / sentry

Developer-first error tracking and performance monitoring

https://sentry.io

Other

37.08k stars 3.98k forks source link

fix(replay): Handle invalid canvas id uniformly #70047

Closed billyvg closed 2 weeks ago

billyvg commented 2 weeks ago

Change to always handle exceptions from processEvent in a uniform manner. Will always use a metric if canvas id was not found, otherwise capture exception to Sentry.

Fixes JAVASCRIPT-2SWZ Fixes JAVASCRIPT-2SHT

sentry-io[bot] commented 2 weeks ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: static/app/components/replays/canvasReplayerPlugin.tsx

Function	Unhandled Issue
`CanvasReplayerPlugin`	Error: No canvas found for id processEvent(app/co... `Event Count:` 1 `Affected Users:` 19

_{Did you find this useful? React with a 👍 or 👎}