search

getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.08k stars 3.98k forks source link

feat(performance):Adds discover spans metrics support for queue module mertics and tags #70062

Closed edwardgou-sentry closed 2 weeks ago

edwardgou-sentry commented 2 weeks ago

Adds trace.status and messaging.destination.name as tags to spans metrics dataset. Adds messaging.message.receive.latency as a gauge metric and add gauge resolver to avg in the spans metrics dataset.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.84%. Comparing base (fa09309) to head (9653ba3). Report is 74 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70062 +/- ## ======================================== Coverage 79.83% 79.84% ======================================== Files 6500 6502 +2 Lines 289069 289170 +101 Branches 49777 49797 +20 ======================================== + Hits 230779 230878 +99 - Misses 57932 57934 +2 Partials 358 358 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/70062?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [src/sentry/search/events/constants.py](https://app.codecov.io/gh/getsentry/sentry/pull/70062?src=pr&el=tree&filepath=src%2Fsentry%2Fsearch%2Fevents%2Fconstants.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9zZWFyY2gvZXZlbnRzL2NvbnN0YW50cy5weQ==) | `100.00% <ø> (ø)` | | | [src/sentry/search/events/datasets/spans\_metrics.py](https://app.codecov.io/gh/getsentry/sentry/pull/70062?src=pr&el=tree&filepath=src%2Fsentry%2Fsearch%2Fevents%2Fdatasets%2Fspans_metrics.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9zZWFyY2gvZXZlbnRzL2RhdGFzZXRzL3NwYW5zX21ldHJpY3MucHk=) | `87.89% <100.00%> (+0.15%)` | :arrow_up: | | [src/sentry/utils/snuba.py](https://app.codecov.io/gh/getsentry/sentry/pull/70062?src=pr&el=tree&filepath=src%2Fsentry%2Futils%2Fsnuba.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS91dGlscy9zbnViYS5weQ==) | `93.62% <ø> (ø)` | | ... and [67 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/70062/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)