getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.08k stars 3.98k forks source link

feat(performance): Add split by char optimization to projects #70076

Open wmak opened 2 weeks ago

wmak commented 2 weeks ago
sentry-io[bot] commented 2 weeks ago

πŸ” Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

πŸ“„ File: src/sentry/search/events/builder/discover.py

Function Unhandled Issue
resolve_params UnqualifiedQueryError: You need to specify at least one project. sentry.tasks.activity.send_activi...
Event Count: 3

Did you find this useful? React with a πŸ‘ or πŸ‘Ž

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.83%. Comparing base (7e8fbec) to head (39867d9). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70076 +/- ## ========================================== + Coverage 77.94% 79.83% +1.89% ========================================== Files 6502 6502 Lines 289243 289261 +18 Branches 49811 49813 +2 ========================================== + Hits 225442 230927 +5485 + Misses 63387 57923 -5464 + Partials 414 411 -3 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/70076?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Ξ” | | |---|---|---| | [src/sentry/options/defaults.py](https://app.codecov.io/gh/getsentry/sentry/pull/70076?src=pr&el=tree&filepath=src%2Fsentry%2Foptions%2Fdefaults.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9vcHRpb25zL2RlZmF1bHRzLnB5) | `100.00% <100.00%> (ΓΈ)` | | | [src/sentry/search/events/builder/discover.py](https://app.codecov.io/gh/getsentry/sentry/pull/70076?src=pr&el=tree&filepath=src%2Fsentry%2Fsearch%2Fevents%2Fbuilder%2Fdiscover.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9zZWFyY2gvZXZlbnRzL2J1aWxkZXIvZGlzY292ZXIucHk=) | `96.12% <80.00%> (+0.01%)` | :arrow_up: | ... and [446 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/70076/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)