getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.08k stars 3.98k forks source link

cogs(ownership): remove logs in project ownership #70078

Closed JoshFerge closed 2 weeks ago

JoshFerge commented 2 weeks ago

these logs are too noisy and expensive, removing them. if we want high level info about this flow, we should add metrics. If we want to debug a small subset, we should add spans and relay on tracing in order to debug them.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.83%. Comparing base (9a31bb0) to head (cc0decf). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70078 +/- ## =========================================== + Coverage 58.39% 79.83% +21.44% =========================================== Files 6490 6502 +12 Lines 288802 289216 +414 Branches 49750 49806 +56 =========================================== + Hits 168641 230894 +62253 + Misses 119745 57911 -61834 + Partials 416 411 -5 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/70078?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [src/sentry/models/projectownership.py](https://app.codecov.io/gh/getsentry/sentry/pull/70078?src=pr&el=tree&filepath=src%2Fsentry%2Fmodels%2Fprojectownership.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9tb2RlbHMvcHJvamVjdG93bmVyc2hpcC5weQ==) | `95.87% <ø> (+50.10%)` | :arrow_up: | ... and [1933 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/70078/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)