search

getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.08k stars 3.98k forks source link

chore(superuser): use option for read-write instead of FF #70083

Closed cathteng closed 2 weeks ago

cathteng commented 2 weeks ago

Part 1 of replacing the superuser read-write feature flag with an option. There's code in getsentry that is using the flag, so we can't completely remove it yet.

The flag is not currently turned on, so using an OR for either the option or the flag for the logic is fine. This will be temporary.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.83%. Comparing base (e355dc0) to head (f663080). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70083 +/- ## =========================================== + Coverage 62.92% 79.83% +16.90% =========================================== Files 6496 6502 +6 Lines 288948 289236 +288 Branches 49777 49810 +33 =========================================== + Hits 181821 230907 +49086 + Misses 106710 57918 -48792 + Partials 417 411 -6 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/70083?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [src/sentry/auth/superuser.py](https://app.codecov.io/gh/getsentry/sentry/pull/70083?src=pr&el=tree&filepath=src%2Fsentry%2Fauth%2Fsuperuser.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9hdXRoL3N1cGVydXNlci5weQ==) | `93.44% <100.00%> (+18.03%)` | :arrow_up: | | [src/sentry/options/defaults.py](https://app.codecov.io/gh/getsentry/sentry/pull/70083?src=pr&el=tree&filepath=src%2Fsentry%2Foptions%2Fdefaults.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9vcHRpb25zL2RlZmF1bHRzLnB5) | `100.00% <100.00%> (ø)` | | ... and [1765 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/70083/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)