search

getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.08k stars 3.98k forks source link

ref: type sentry.utils.sms and sentry.utils.otp #70084

Closed asottile-sentry closed 1 week ago

asottile-sentry commented 2 weeks ago

planning to refactor this to be a little more typesafe -- but typing it first so the refactor is more apparent and not lost in this

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.83%. Comparing base (4a5cc77) to head (454fe40). Report is 22 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70084 +/- ## ========================================== + Coverage 78.88% 79.83% +0.95% ========================================== Files 6502 6503 +1 Lines 289178 289199 +21 Branches 49799 49802 +3 ========================================== + Hits 228124 230895 +2771 + Misses 60643 57893 -2750 Partials 411 411 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/70084?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [src/sentry/auth/authenticators/\_\_init\_\_.py](https://app.codecov.io/gh/getsentry/sentry/pull/70084?src=pr&el=tree&filepath=src%2Fsentry%2Fauth%2Fauthenticators%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9hdXRoL2F1dGhlbnRpY2F0b3JzL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [src/sentry/auth/authenticators/sms.py](https://app.codecov.io/gh/getsentry/sentry/pull/70084?src=pr&el=tree&filepath=src%2Fsentry%2Fauth%2Fauthenticators%2Fsms.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9hdXRoL2F1dGhlbnRpY2F0b3JzL3Ntcy5weQ==) | `91.04% <100.00%> (+0.13%)` | :arrow_up: | | [src/sentry/auth/authenticators/totp.py](https://app.codecov.io/gh/getsentry/sentry/pull/70084?src=pr&el=tree&filepath=src%2Fsentry%2Fauth%2Fauthenticators%2Ftotp.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9hdXRoL2F1dGhlbnRpY2F0b3JzL3RvdHAucHk=) | `100.00% <100.00%> (ø)` | | | [src/sentry/utils/otp.py](https://app.codecov.io/gh/getsentry/sentry/pull/70084?src=pr&el=tree&filepath=src%2Fsentry%2Futils%2Fotp.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS91dGlscy9vdHAucHk=) | `67.69% <100.00%> (+0.50%)` | :arrow_up: | | [src/sentry/auth/authenticators/base.py](https://app.codecov.io/gh/getsentry/sentry/pull/70084?src=pr&el=tree&filepath=src%2Fsentry%2Fauth%2Fauthenticators%2Fbase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9hdXRoL2F1dGhlbnRpY2F0b3JzL2Jhc2UucHk=) | `80.00% <95.65%> (-0.63%)` | :arrow_down: | | [src/sentry/utils/sms.py](https://app.codecov.io/gh/getsentry/sentry/pull/70084?src=pr&el=tree&filepath=src%2Fsentry%2Futils%2Fsms.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS91dGlscy9zbXMucHk=) | `82.85% <75.00%> (+4.80%)` | :arrow_up: | ... and [247 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/70084/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)