search

getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.08k stars 3.98k forks source link

feat(slack): Change text in slack threads #70087

Closed ykamo001 closed 2 weeks ago

ykamo001 commented 2 weeks ago

When creating a slack notification for threads, use "this issue" instead of explicitly adding the issue name

ykamo001 commented 2 weeks ago

do we have tests to check the contents of the message? might have to change those?

I can add some tests

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.83%. Comparing base (286df45) to head (2cdb16e). Report is 11 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70087 +/- ## =========================================== + Coverage 54.15% 79.83% +25.68% =========================================== Files 5490 6503 +1013 Lines 231103 289252 +58149 Branches 39709 49812 +10103 =========================================== + Hits 125147 230918 +105771 + Misses 105546 57923 -47623 - Partials 410 411 +1 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/70087?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [src/sentry/integrations/slack/service.py](https://app.codecov.io/gh/getsentry/sentry/pull/70087?src=pr&el=tree&filepath=src%2Fsentry%2Fintegrations%2Fslack%2Fservice.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9pbnRlZ3JhdGlvbnMvc2xhY2svc2VydmljZS5weQ==) | `63.15% <100.00%> (ø)` | | | [...tegrations/slack/threads/activity\_notifications.py](https://app.codecov.io/gh/getsentry/sentry/pull/70087?src=pr&el=tree&filepath=src%2Fsentry%2Fintegrations%2Fslack%2Fthreads%2Factivity_notifications.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9pbnRlZ3JhdGlvbnMvc2xhY2svdGhyZWFkcy9hY3Rpdml0eV9ub3RpZmljYXRpb25zLnB5) | `100.00% <100.00%> (ø)` | | ... and [2257 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/70087/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)