getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.08k stars 3.98k forks source link

feat(issue-search): implements x-hits and cursor logic for snuba only search #70089

Closed scefali closed 2 weeks ago

scefali commented 2 weeks ago

This PR makes sure we properly set the X-Hits and pagination logic for the new snuba only search. One thing I want to call out is that there might be issues when issues are pending deletion or being merged. We may return less than a full page of results in that case. This problem is likely worse than the postgres only search because we aren't checking PG for issue state before hitting Snuba.

Note that I am not sure about some of the logic overriding the default behavior for has_results. The existing logic is somewhat convoluted and I'm not sure we actually need it.

I also added more filters that we currently don't support for snuba only search. Some of them like firstSeen should be easy to support while others are harder.

sentry-io[bot] commented 2 weeks ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎