getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.08k stars 3.98k forks source link

chore(actor) Remove Team.actor_id from state #70090

Closed markstory closed 2 weeks ago

markstory commented 2 weeks ago

Refs HC-1176

github-actions[bot] commented 2 weeks ago

This PR has a migration; here is the generated SQL for src/sentry/migrations/0712_team_remove_actor_state.py ()

--
-- Custom state/database change combination
--

                    ALTER TABLE "sentry_team" DROP CONSTRAINT IF EXISTS "sentry_team_actor_idx_fk_sentry_actor_id"
                    ;
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.86%. Comparing base (c0e6ebb) to head (ca2768a). Report is 8 commits behind head on master.

:exclamation: Current head ca2768a differs from pull request most recent head fbf46b1. Consider uploading reports for the commit fbf46b1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70090 +/- ## =========================================== + Coverage 58.37% 79.86% +21.49% =========================================== Files 6497 6504 +7 Lines 289189 289172 -17 Branches 49814 49788 -26 =========================================== + Hits 168804 230947 +62143 + Misses 119967 57815 -62152 + Partials 418 410 -8 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/70090?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [src/sentry/backup/comparators.py](https://app.codecov.io/gh/getsentry/sentry/pull/70090?src=pr&el=tree&filepath=src%2Fsentry%2Fbackup%2Fcomparators.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9iYWNrdXAvY29tcGFyYXRvcnMucHk=) | `98.06% <ø> (+13.17%)` | :arrow_up: | | [src/sentry/backup/dependencies.py](https://app.codecov.io/gh/getsentry/sentry/pull/70090?src=pr&el=tree&filepath=src%2Fsentry%2Fbackup%2Fdependencies.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9iYWNrdXAvZGVwZW5kZW5jaWVzLnB5) | `95.77% <ø> (+5.39%)` | :arrow_up: | | [src/sentry/backup/imports.py](https://app.codecov.io/gh/getsentry/sentry/pull/70090?src=pr&el=tree&filepath=src%2Fsentry%2Fbackup%2Fimports.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9iYWNrdXAvaW1wb3J0cy5weQ==) | `97.22% <100.00%> (+0.46%)` | :arrow_up: | | [src/sentry/models/actor.py](https://app.codecov.io/gh/getsentry/sentry/pull/70090?src=pr&el=tree&filepath=src%2Fsentry%2Fmodels%2Factor.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9tb2RlbHMvYWN0b3IucHk=) | `66.66% <100.00%> (+15.36%)` | :arrow_up: | | [src/sentry/models/team.py](https://app.codecov.io/gh/getsentry/sentry/pull/70090?src=pr&el=tree&filepath=src%2Fsentry%2Fmodels%2Fteam.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9tb2RlbHMvdGVhbS5weQ==) | `99.18% <100.00%> (+14.10%)` | :arrow_up: | | [src/sentry/testutils/helpers/backups.py](https://app.codecov.io/gh/getsentry/sentry/pull/70090?src=pr&el=tree&filepath=src%2Fsentry%2Ftestutils%2Fhelpers%2Fbackups.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS90ZXN0dXRpbHMvaGVscGVycy9iYWNrdXBzLnB5) | `99.70% <ø> (+2.34%)` | :arrow_up: | | [src/sentry/testutils/silo.py](https://app.codecov.io/gh/getsentry/sentry/pull/70090?src=pr&el=tree&filepath=src%2Fsentry%2Ftestutils%2Fsilo.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS90ZXN0dXRpbHMvc2lsby5weQ==) | `89.63% <ø> (+21.14%)` | :arrow_up: | ... and [1968 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/70090/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)
github-actions[bot] commented 2 weeks ago

This PR has a migration; here is the generated SQL for src/sentry/migrations/0713_team_remove_actor_state.py ()

--
-- Custom state/database change combination
--

                    ALTER TABLE "sentry_team" DROP CONSTRAINT IF EXISTS "sentry_team_actor_idx_fk_sentry_actor_id"
                    ;