getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.08k stars 3.98k forks source link

Activated Alert rule detail #70092

Closed nhsiehgit closed 1 week ago

nhsiehgit commented 2 weeks ago

Display activated alert rule activations and activator within the details page

Screenshot 2024-05-01 at 2 45 17 PM

github-actions[bot] commented 2 weeks ago

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.82%. Comparing base (b33b16f) to head (876bb65).

:exclamation: Current head 876bb65 differs from pull request most recent head 8fc9645. Consider uploading reports for the commit 8fc9645 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70092 +/- ## ======================================= Coverage 79.82% 79.82% ======================================= Files 6504 6504 Lines 289384 289349 -35 Branches 49834 49830 -4 ======================================= - Hits 230992 230965 -27 + Misses 57981 57973 -8 Partials 411 411 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/70092?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [...y/api/serializers/models/alert\_rule\_activations.py](https://app.codecov.io/gh/getsentry/sentry/pull/70092?src=pr&el=tree&filepath=src%2Fsentry%2Fapi%2Fserializers%2Fmodels%2Falert_rule_activations.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9hcGkvc2VyaWFsaXplcnMvbW9kZWxzL2FsZXJ0X3J1bGVfYWN0aXZhdGlvbnMucHk=) | `100.00% <ø> (ø)` | | | [src/sentry/api/serializers/models/incident.py](https://app.codecov.io/gh/getsentry/sentry/pull/70092?src=pr&el=tree&filepath=src%2Fsentry%2Fapi%2Fserializers%2Fmodels%2Fincident.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9hcGkvc2VyaWFsaXplcnMvbW9kZWxzL2luY2lkZW50LnB5) | `100.00% <ø> (ø)` | | | [src/sentry/incidents/subscription\_processor.py](https://app.codecov.io/gh/getsentry/sentry/pull/70092?src=pr&el=tree&filepath=src%2Fsentry%2Fincidents%2Fsubscription_processor.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9pbmNpZGVudHMvc3Vic2NyaXB0aW9uX3Byb2Nlc3Nvci5weQ==) | `91.73% <ø> (ø)` | | | [...tic/app/views/alerts/rules/metric/details/body.tsx](https://app.codecov.io/gh/getsentry/sentry/pull/70092?src=pr&el=tree&filepath=static%2Fapp%2Fviews%2Falerts%2Frules%2Fmetric%2Fdetails%2Fbody.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3RhdGljL2FwcC92aWV3cy9hbGVydHMvcnVsZXMvbWV0cmljL2RldGFpbHMvYm9keS50c3g=) | `70.00% <ø> (ø)` | | | [...iews/alerts/rules/metric/details/metricHistory.tsx](https://app.codecov.io/gh/getsentry/sentry/pull/70092?src=pr&el=tree&filepath=static%2Fapp%2Fviews%2Falerts%2Frules%2Fmetric%2Fdetails%2FmetricHistory.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3RhdGljL2FwcC92aWV3cy9hbGVydHMvcnVsZXMvbWV0cmljL2RldGFpbHMvbWV0cmljSGlzdG9yeS50c3g=) | `93.33% <ø> (+3.33%)` | :arrow_up: | | [static/app/views/alerts/rules/metric/types.tsx](https://app.codecov.io/gh/getsentry/sentry/pull/70092?src=pr&el=tree&filepath=static%2Fapp%2Fviews%2Falerts%2Frules%2Fmetric%2Ftypes.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3RhdGljL2FwcC92aWV3cy9hbGVydHMvcnVsZXMvbWV0cmljL3R5cGVzLnRzeA==) | `100.00% <ø> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/70092/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)
codecov[bot] commented 2 weeks ago

Bundle Report

Changes will increase total bundle size by 6.13kB :arrow_up:

Bundle name Size Change
app-webpack-bundle-array-push 26.57MB 6.13kB :arrow_up:
sentry-io[bot] commented 1 day ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎