search

getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.08k stars 3.98k forks source link

fix(feedback): add feedback shimming to event manager #70117

Closed JoshFerge closed 2 weeks ago

JoshFerge commented 2 weeks ago

If we determine it is okay to do so, we shim user reports to user feedback in the event_manager.

depends on https://github.com/getsentry/sentry/pull/70116

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.82%. Comparing base (156f9f7) to head (f1b1950). Report is 2 commits behind head on master.

:exclamation: Current head f1b1950 differs from pull request most recent head 157b5e5. Consider uploading reports for the commit 157b5e5 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70117 +/- ## ========================================== + Coverage 74.48% 79.82% +5.33% ========================================== Files 6507 6504 -3 Lines 289593 289369 -224 Branches 49869 49829 -40 ========================================== + Hits 215706 230983 +15277 + Misses 73385 57975 -15410 + Partials 502 411 -91 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/70117?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [src/sentry/conf/server.py](https://app.codecov.io/gh/getsentry/sentry/pull/70117?src=pr&el=tree&filepath=src%2Fsentry%2Fconf%2Fserver.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9jb25mL3NlcnZlci5weQ==) | `89.15% <ø> (ø)` | | | [src/sentry/features/temporary.py](https://app.codecov.io/gh/getsentry/sentry/pull/70117?src=pr&el=tree&filepath=src%2Fsentry%2Ffeatures%2Ftemporary.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9mZWF0dXJlcy90ZW1wb3JhcnkucHk=) | `100.00% <100.00%> (ø)` | | ... and [936 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/70117/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)
JoshFerge commented 2 weeks ago

closing as we're gonna move this whole flow to post process instead. PR incoming