search

getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.33k stars 4.01k forks source link

ref: remove get_canonical_name from interfaces setup #70939

Closed asottile-sentry closed 4 weeks ago

asottile-sentry commented 4 weeks ago

prod metrics show that the name passed to this is always canonical already

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.91%. Comparing base (893a38b) to head (0ceb55a). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70939 +/- ## ========================================== - Coverage 77.91% 77.91% -0.01% ========================================== Files 6512 6512 Lines 290115 290114 -1 Branches 50218 50218 ========================================== - Hits 226050 226044 -6 - Misses 57774 57775 +1 - Partials 6291 6295 +4 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/70939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [src/sentry/interfaces/base.py](https://app.codecov.io/gh/getsentry/sentry/pull/70939?src=pr&el=tree&filepath=src%2Fsentry%2Finterfaces%2Fbase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9pbnRlcmZhY2VzL2Jhc2UucHk=) | `88.67% <100.00%> (-0.11%)` | :arrow_down: | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/70939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)