Closed malwilley closed 3 weeks ago
Changes will increase total bundle size by 17.57kB :arrow_up:
Bundle name | Size | Change |
---|---|---|
app-webpack-bundle-array-push | 27.67MB | 17.57kB :arrow_up: |
@evanpurkhiser I found a fixed a couple other edge cases I found if you want to take another look!
Ref https://github.com/getsentry/sentry/issues/70953
For the new search component, parens will need to be parsed as separate tokens and the parser cannot error out when faced with mismatched parens. Therefore the parser should be updated to allow for this.
I've added a new token type,
PAREN
, which may be returned as part of the parse result. When there are mismatched parentheses, this is now matched which allows the parser to return a successful result. A new config option has been added,flattenParenGroups
(name could be workshopped), which causes thePAREN
token to take precedence overLOGIC_GROUP
and thus return parens separately from the contents when enabled. When disabled (the default), logic groups are still returned as you would expect.Previous behavior:
LOGIC_GROUP
with boolean operators, free text, and filters inside thetoken.inner
array.New behavior (with the default
flattenParenGroups=false
):PAREN
token.LOGIC_GROUP
as normal.New behavior (with the new
flattenParenGroups=true
):PAREN
token.LOGIC_GROUP
You can see now that syntax highlighting is no longer broken when adding a mismatched paren: