getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.33k stars 4.01k forks source link

chore(metrics-layer): Clean up meta queries to always use storage direct queries #70962

Closed enochtangg closed 3 weeks ago

enochtangg commented 4 weeks ago

After rolling out meta queries to directly query a storage in snuba, we can remove the sentry option and the logic that samples these queries.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.92%. Comparing base (bc6a0f8) to head (2b84960). Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70962 +/- ## ======================================= Coverage 77.91% 77.92% ======================================= Files 6512 6512 Lines 290214 290209 -5 Branches 50236 50234 -2 ======================================= + Hits 226122 226132 +10 + Misses 57798 57787 -11 + Partials 6294 6290 -4 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/70962?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [src/sentry/snuba/metrics\_layer/query.py](https://app.codecov.io/gh/getsentry/sentry/pull/70962?src=pr&el=tree&filepath=src%2Fsentry%2Fsnuba%2Fmetrics_layer%2Fquery.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9zbnViYS9tZXRyaWNzX2xheWVyL3F1ZXJ5LnB5) | `90.56% <100.00%> (+1.09%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/70962/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)