getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.23k stars 4k forks source link

add loggers to comparison aggregations #71088

Closed nhsiehgit closed 2 weeks ago

nhsiehgit commented 2 weeks ago

I'll add a TODO and note that this is for investigation and should be removed

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.89%. Comparing base (29883d3) to head (a234144). Report is 25 commits behind head on master.

:exclamation: Current head a234144 differs from pull request most recent head 5b775cd

Please upload reports for the commit 5b775cd to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #71088 +/- ## =========================================== + Coverage 55.66% 77.89% +22.23% =========================================== Files 6511 6521 +10 Lines 290191 290546 +355 Branches 50210 50268 +58 =========================================== + Hits 161534 226335 +64801 + Misses 124298 57967 -66331 - Partials 4359 6244 +1885 ``` | [Files](https://app.codecov.io/gh/getsentry/sentry/pull/71088?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry) | Coverage Δ | | |---|---|---| | [src/sentry/incidents/subscription\_processor.py](https://app.codecov.io/gh/getsentry/sentry/pull/71088?src=pr&el=tree&filepath=src%2Fsentry%2Fincidents%2Fsubscription_processor.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry#diff-c3JjL3NlbnRyeS9pbmNpZGVudHMvc3Vic2NyaXB0aW9uX3Byb2Nlc3Nvci5weQ==) | `89.01% <50.00%> (+69.95%)` | :arrow_up: | ... and [2011 files with indirect coverage changes](https://app.codecov.io/gh/getsentry/sentry/pull/71088/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=getsentry)