Closed Jesse-Box closed 1 week ago
@Jesse-Box what did you mean by "Vertical spacing between email address and feedback preview is awkward when compared with the feedback preview and the footer information (project name + icons)"?
With the updated font sizes, the UI now looks like this - the name part is 14px
, all other text is 12px
.
We leave room at the bottom of 1-line feedback previews to account for the space that 2-line previews take up; otherwise the heights of the feedback cards wouldn't all be consistent. Did you have a different spacing in mind? (currently the gap
is 8px
which is what it looks to be in the figma
Unrelated to the spacing -- it's also significantly harder to tell which feedback is unread vs read after getting rid of the purple dot
what did you mean by "Vertical spacing between email address and feedback preview is awkward when compared with the feedback preview and the footer information (project name + icons)"?
I DM'd you a rewatch video, since it contains customer data. Hopefully, that explains myself as well!
We leave room at the bottom of 1-line feedback previews to account for the space that 2-line previews take up; otherwise the heights of the feedback cards wouldn't all be consistent.
Here are my thoughts on this point right now. In practice, implementing a static height for the feedback preview results in the footer information being visually linked to the subsequent feedback item, rather than the feedback item it is actually linked to. Ideally, we can preview up to two lines of feedback, but if their feedback is short, the feedback preview height is reduced to compensate. Alternatively, we only show one line of feedback.
Unrelated to the spacing -- it's also significantly harder to tell which feedback is unread vs read after getting rid of the purple dot.
I heard this from Ryan as well, so maybe this was a stupid idea… Can you re-introduce the dot? Sorry about that!
Problems
Solution
See Figma Library
Component in Isolation![Image](https://github.com/getsentry/sentry/assets/6508377/d8dd9b19-c4da-497d-9243-dcecb6bcf483)
Component in Composition![Image](https://github.com/getsentry/sentry/assets/6508377/764f74fa-eae7-488d-b011-e4705525413e)