Stack Trace Rules bypass recusion check

lhunath commented 6 days ago

Environment

Steps to Reproduce

Specify a stack trace rule for a frame which may appear in a recursion
Produce an error where the frame participates in a stack recursion
Observe the grouping of the error event's stack

eg.

stack.package:**/UIKitCore stack.function:[-+]\[* +group

Expected Result

The first frame is un-ignored per the stack trace rule.
The recursing frames are ignored on account of recursion.

frame (un-ignored by stack trace rule (package:**/SwiftUI function:[-+]\[* +group))
    function -[UIScrollView(SwiftUI) _swiftui_adjustsContentInsetWhenScrollDisabled]
frame (ignored due to recursion)
    function -[UIScrollView(SwiftUI) _swiftui_adjustsContentInsetWhenScrollDisabled]
frame (ignored due to recursion)
    function -[UIScrollView(SwiftUI) _swiftui_adjustsContentInsetWhenScrollDisabled]

Actual Result

Every frame that matches the rule, including the recusing frames, are un-ignored.

frame (un-ignored by stack trace rule (package:**/SwiftUI function:[-+]\[* +group))
    function -[UIScrollView(SwiftUI) _swiftui_adjustsContentInsetWhenScrollDisabled]
frame (un-ignored by stack trace rule (package:**/SwiftUI function:[-+]\[* +group))
    function -[UIScrollView(SwiftUI) _swiftui_adjustsContentInsetWhenScrollDisabled]
frame (un-ignored by stack trace rule (package:**/SwiftUI function:[-+]\[* +group))
    function -[UIScrollView(SwiftUI) _swiftui_adjustsContentInsetWhenScrollDisabled]

It doesn't seem to be desirable to make the default behaviour be the one that is least useful, this makes the group sensitive to the # of recursions which is not the default Sentry stack grouping behaviour.

Furthermore, there is no simple way to restore the recursive check. One might be forced to explicitly write out sibling rules for each standard rule just to restore the default recursion behaviour. A recursion:yes/no matcher might be a useful addition if flipping the default behaviour by itself is inadequate.