Crons issues have an invalid span ID

getsentry / sentry

Developer-first error tracking and performance monitoring

https://sentry.io

Other

38.52k stars 4.12k forks source link

Crons issues have an invalid span ID #74026

Open gaprl opened 2 months ago

gaprl commented 2 months ago

Currently, Crons issues (for failed check-ins) have invalid span IDs:

Consequently, any monitor failure issues do not show up in the trace view:

It should have a valid span ID and appear in the same trace view so it is easy to understand the monitor failure is related to any other issues/spans.

k-fish commented 1 month ago

This isn't a representation issue, this has to do with how crons create issues

https://github.com/getsentry/sentry/blob/2f9a58ca627224ccce979e996d8c4fd4fea8fa6a/src/sentry/monitors/logic/mark_failed.py#L297-L298

The crons code here for issues platform is making an event without span data, it's explicitly set to None here, you'll need to figure out what you want that to be instead and what you expect to represent here.

getsantry[bot] commented 1 month ago

Routing to @getsentry/product-owners-crons for triage ⏲️