getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
37.7k stars 4.05k forks source link

Custom sampling frequency for profiling #74069

Open aleksanb opened 2 weeks ago

aleksanb commented 2 weeks ago

Problem Statement

Today, the sampling frequency for performance tracing is capped at 100hz. We'd like to set this to something custom, perhaps 200hz to get more accurate flamegraphs.

Solution Brainstorm

No response

Product Area

Performance

getsantry[bot] commented 2 weeks ago

Assigning to @getsentry/support for routing ⏲️

getsantry[bot] commented 2 weeks ago

Routing to @getsentry/product-owners-performance for triage ⏲️

Dhrumil-Sentry commented 2 weeks ago

Thank you for this feedback. The sampling frequency for profiles is fixed at 101hz and is not user configurable. One of the main reasons being higher frequencies will cause additional load.

We will keep this in our backlog but we don't anticipate working on this in the near-mid term

aleksanb commented 2 weeks ago

I'm aware of the increased performance impact, and willing to take the hit for more fine grained profiling on our app servers. Being able to self configure this would only make things slower for my own organization.

Is it a data cost question on sentry's side? 200hz would shovel twice the data amount through your servers. If so i see why making the flag user configurable could takr more time, if it had to increase the profile cost to 1.4 or more for instance.