Deprecate culprit field (DRAFT)

getsentry / sentry

Developer-first error tracking and performance monitoring

https://sentry.io

Other

38.53k stars 4.12k forks source link

Deprecate culprit field (DRAFT) #74226

Open armenzg opened 2 months ago

armenzg commented 2 months ago

This will prevent confusion as to the one which happened in #73717.

NOTE: This is a draft. Feedback wanted

[ ] Prevent selecting culprit in the UI
[ ] Add a transaction field to the Group model (run side-by-side or backfill)
- [ ] Make the Issue Details page try using the transaction when available instead of the culprit field
[ ] Stop generating culprit for events
[ ] Drop culprit from Group after 90 days

lobsterkatie commented 2 months ago

My only concern is that in replacing culprit with transaction and a data source, we may be missing all the events which use something else as the culprit. See this function (and the other functions in that file) for examples of what else we use.

mrduncan commented 2 months ago

Are we storing culprit information anywhere else which would need to be migrated? Ex: for search