search

getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
38.42k stars 4.11k forks source link

Metric is not collected if there is disabled metric with same name but in upper case #74343

Closed alx-mag closed 1 month ago

alx-mag commented 1 month ago

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Send counter metric with name AN_ACTION
  2. Disable this metric in Metric Details page
  3. Send counter metric with name an_action

Expected Result

Metrics with name an_action are collected and became visible on metrics chart

Actual Result

Metrics with name an_action are ignored and don't appear in chart, unless we enable AN_ACTION metrics back

Product Area

Unknown

Link

No response

DSN

No response

Version

No response

getsantry[bot] commented 1 month ago

Assigning to @getsentry/support for routing ⏲️

getsantry[bot] commented 1 month ago

Routing to @getsentry/product-owners-performance for triage ⏲️

getsantry[bot] commented 1 month ago

Routing to @getsentry/product-owners-ddm for triage ⏲️

matejminar commented 1 month ago

Hi, thanks for reporting this. We're investigating what's going on.

jan-auer commented 1 month ago

So far, we've treated metric names as case sensitive. This is therefore a bug in Relay's matching logic (here). The underlying glob pattern used to match the name is always case insensitive (here).

However, we can consider to make metric names case insensitive.

matejminar commented 1 month ago

After an internal discussion, we decided not to fix this at the moment because we're in the process of changing the metrics API, and things will change.

More information can be found here: https://sentry.zendesk.com/hc/en-us/articles/26369339769883-Upcoming-API-Changes-to-Metrics

Please, in the meantime, work around this by using a different name for the metric, and we'll make sure this is not an issue in the new solution.