search

getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
38.84k stars 4.16k forks source link

UI Warning for empty Stack Trace Root #76131

Open sdzhong opened 1 month ago

sdzhong commented 1 month ago

Problem Statement

For Code Mappings, it is risky to have an empty Stack Trace Root value since it matches all stack traces and means the other rules won't be applied. A warning is in the docs:

For best results, we recommend always providing a non-empty value for the Stack Trace Root when possible.

When adding Code Mappings, it's very easy to add an empty Stack Trace Root Code Mapping which could inadvertently prevent all other code mappings from working correctly.

https://github.com/user-attachments/assets/b01cd25f-a385-43a8-bfeb-68c516427074

Solution Brainstorm

Add a warning in the UI when the user attempts to add a Code Mapping with an empty value for the Stack Trace Root. The warning would describe the risk of this Code Mapping.

Product Area

Settings - Integrations

getsantry[bot] commented 1 month ago

Auto-routing to @getsentry/product-owners-issues for triage ⏲️

mrduncan commented 1 month ago

I really like the idea of surfacing this - adding to our core product rotation backlog for prioritization

armenzg commented 1 month ago

Whoever works on this. Please let them talk to me before implemeting