Cleanup FileBlob

[Meraj]

Environment

Repository: getsentry/sentry Version: 24.7.1

Description

Hi, While reviewing the source code, I noticed the cleanup command for file blobs performs a full iteration over all FileBlob objects to check for related FileBlobIndex or File objects before deciding whether to delete the blob.

The relevant code can be found here: https://github.com/getsentry/sentry/blob/master/src/sentry/runner/commands/cleanup.py#L403C1-L429C22

    for blob in RangeQuerySetWrapper(queryset):
        if FileBlobIndex.objects.filter(blob=blob).exists():
            continue
        if File.objects.filter(blob=blob).exists():
            continue
        blob.delete()

Wouldn't it be more efficient to handle this directly within the ORM? For example:

queryset = FileBlob.objects.filter(
    timestamp__lte=cutoff
).exclude(
    Q(fileblobindex__isnull=False) | Q(file__isnull=False)
)

This approach could potentially improve performance, especially when processing a large number of files.

[getsantry[bot]]

Assigning to @getsentry/support for routing ⏲️

[getsantry[bot]]

Assigning to @getsentry/support for routing ⏲️

[getsantry[bot]]

Routing to @getsentry/product-owners-unknown for triage ⏲️