getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
38.91k stars 4.17k forks source link

"Invalid" tag highlight fails to update when tag list changes #77275

Open dstekol opened 1 month ago

dstekol commented 1 month ago

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Open an error page where at least one of the tags has a red "" highlight
  2. Click on the different tag filters, ex. All, Custom, Application, Client, Other

Expected Result

The tag that was initially highlighted as invalid is consistently highlighted, and the red highlight disappears when the invalid tag is filtered out.

Actual Result

The red highlight remains in the same list position. For example, you can see in the screenshots that when the "All" filter is selected, exc_info is highlighted red as invalid (note that it's the 4th item in the list). When I switch to "custom", the internal_product_id (the 4th option in the list) becomes highlighted, even though it was not highlighted before. When I switch to "application", server_name (again the 4th item) is highlighted instead, and same for when I click Other. It seems that once the initial tag list is rendered, items in the list are highlighted based on the position in the list rather than on the content, which means when the list is updated, the highlight remains in the same place even though that is no longer correct.

Image Image Image Image

Product Area

Issues

Link

No response

DSN

No response

Version

No response

getsantry[bot] commented 1 month ago

Auto-routing to @getsentry/product-owners-issues for triage ⏲️

MichaelSun48 commented 1 month ago

Hey @dstekol 👋 thanks for writing in and catching this! This definitely looks like a bug – would you mind providing a link to this issue so I could take a closer look?

dstekol commented 1 month ago

https://albycom.sentry.io/issues/5799441258/?environment=Environments.prod&environment=prod&project=4507188449902592&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&statsPeriod=14d&stream_index=0

Hey @dstekol 👋 thanks for writing in and catching this! This definitely looks like a bug – would you mind providing a link to this issue so I could take a closer look?