getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
38.62k stars 4.13k forks source link

Onboarding events adjustments #77391

Open matejminar opened 1 week ago

matejminar commented 1 week ago
  1. Project Creation: Framework Modal Close Button Clicked fires also when you accept the modal (we should have different events for submit, skip, close and each firing only in that one situation) --> https://github.com/getsentry/sentry/pull/77628
  2. Project Create: Project Created can we add property here that identifies the selected platform? --> https://github.com/getsentry/sentry/pull/77629
  3. Page View: Projects :ProjectId Getting-started fired 2x <-- https://github.com/getsentry/getsentry/pull/15174
  4. Project Creation: Data Removal Modal Dismissed fires also when you confirm the modal --> https://github.com/getsentry/sentry/pull/77630
  5. Onboarding: Take Me to Issues Clicked would be nice to know which products were selected --> https://github.com/getsentry/sentry/pull/77623
  6. "Take me to my error" is not instrumented - https://github.com/getsentry/sentry/pull/77627
matejminar commented 3 days ago

@vgrozdanic here's the recorded repro for number 3: https://github.com/user-attachments/assets/56896fc7-a8f8-49ba-af36-ff0e6ad274a6

vgrozdanic commented 2 days ago

On dev env with debug print turned on, this seems like only 1 event is being sent, but when network tab on production is examined, 2 requests are being sent:

// first
{
  "user_id": "3242858",
  "device_id": "52e626d0-116f-45f0-acf1-134dc590c4eb",
  "session_id": 1726751617443,
  "time": 1726752632296,
  "platform": "Web",
  "os_name": "Chrome",
  "os_version": "127.0.0.0",
  "device_model": "Mac OS",
  "language": "en-GB",
  "ip": "$remote",
  "insert_id": "88750a29-df5c-4dd5-a176-97ff1872c0f7",
  "event_type": "Page View: Projects :ProjectId Getting-started",
  "event_properties": {
    "url": "https://vg-test.sentry.io/projects/javascript-y0/getting-started/",
    "user_age": 108,
    "organization_age": 106,
    "parameterized_path": "projects.:project_id.getting-started",
    "analytics_session_id": "957ca2c8-ced2-e054-0621-73d11c4bfea7",
    "role": "owner",
    "plan": "am3_f",
    "can_trial": true,
    "is_trial": false
  },
  "event_id": 12,
  "library": "amplitude-ts/1.5.3"
}
// second - immediately after
{
  "user_id": "3242858",
  "device_id": "52e626d0-116f-45f0-acf1-134dc590c4eb",
  "session_id": 1726751617443,
  "time": 1726752632567,
  "platform": "Web",
  "os_name": "Chrome",
  "os_version": "127.0.0.0",
  "device_model": "Mac OS",
  "language": "en-GB",
  "ip": "$remote",
  "insert_id": "57a09634-4ab6-468b-8c13-134c1a2d0f7f",
  "event_type": "Page View: Projects :ProjectId Getting-started",
  "event_properties": {
    "url": "https://vg-test.sentry.io/projects/javascript-y0/getting-started/?product=performance-monitoring&product=session-replay&showLoader=false",
    "user_age": 108,
    "organization_age": 106,
    "parameterized_path": "projects.:project_id.getting-started",
    "analytics_session_id": "957ca2c8-ced2-e054-0621-73d11c4bfea7",
    "role": "owner",
    "plan": "am3_f",
    "can_trial": true,
    "is_trial": false
  },
  "event_id": 13,
  "library": "amplitude-ts/1.5.3"
}