getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.05k stars 4.19k forks source link

Onboarding documentation incorrect #79822

Open TakesTheBiscuit opened 3 days ago

TakesTheBiscuit commented 3 days ago

How do you use Sentry?

Sentry SaaS (sentry.io)

SDK version

latest

Steps to reproduce

Follow steps

The yaml config shown is wrong, it doesn't use an 'options' child/key:

when@prod:
      sentry:
          dsn: '%env(SENTRY_DSN)%'
          # Specify a fixed sample rate
          traces_sample_rate: 1.0
          # Set a sampling rate for profiling - this is relative to traces_sample_rate
          profiles_sample_rate: 1.0

error thrown:

Unrecognized options "traces_sample_rate, prof
iles_sample_rate" under "sentry". Available op
tions are "dsn", "logger", "messenger", "optio
ns", "register_error_handler", "register_error
_listener", "tracing", "transport_factory".

Correct config seems to be:

when@prod:
    sentry:
        dsn: "%env(SENTRY_DSN)%"
        options:
            # Specify a fixed sample rate
            traces_sample_rate: 1.0
            # Set a sampling rate for profiling - this is relative to traces_sample_rate
            profiles_sample_rate: 1.0

Expected result

Expected onboarding instructions to be accurate, i believe the documentation is out of date with the interface/impl

Actual result

Unrecognized options "traces_sample_rate, prof
iles_sample_rate" under "sentry". Available op
tions are "dsn", "logger", "messenger", "optio
ns", "register_error_handler", "register_error
_listener", "tracing", "transport_factory".

getsantry[bot] commented 3 days ago

Assigning to @getsentry/support for routing ⏲️

cleptric commented 3 days ago

Thansk, we'll get this fixed. The on-boarding code is inside the sentry repo, hence I moved it over there.

getsantry[bot] commented 3 days ago

Routing to @getsentry/product-owners-other for triage ⏲️