getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.23k stars 4.21k forks source link

ref(releases): Function to handle resolved in release #80983

Closed armenzg closed 1 day ago

armenzg commented 3 days ago

This is the largest code block in update_groups. This moves all related logic into a single function.

For the record, I am not focusing on writing better code but on making it more encapsulated. Proper refactors could happen later.

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 85.03937% with 19 lines in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/api/helpers/group_index/update.py 84.92% 6 Missing and 13 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #80983 +/- ## =========================================== + Coverage 56.64% 78.50% +21.85% =========================================== Files 7204 7208 +4 Lines 319280 319315 +35 Branches 43982 43959 -23 =========================================== + Hits 180855 250666 +69811 + Misses 133966 62253 -71713 - Partials 4459 6396 +1937 ```
armenzg commented 1 day ago

I will merge this tomorrow. Thanks @snigdhas !