Closed lobsterkatie closed 10 hours ago
Attention: Patch coverage is 96.15385%
with 1 line
in your changes missing coverage. Please review.
:white_check_mark: All tests successful. No failed tests found.
Files with missing lines | Patch % | Lines |
---|---|---|
src/sentry/grouping/ingest/grouphash_metadata.py | 94.73% | 0 Missing and 1 partial :warning: |
This adds a number of metrics to track grouphash metadata:
grouping.grouphashmetadata.event_hash_basis
- tracks the overall grouping method, including whether or not a hybrid fingerprint was involvedgrouping.grouphashmetadata.event_hashing_metadata.{hash_basis}
- for stacktrace, message, fingerprint, security report, and fallback hashing, tracks certain hashing-method-specific data (seeMETRICS_TAGS_BY_HASH_BASIS
for a list of what's collected)grouping.grouphashmetadata.create_or_update_grouphash_metadata
- times the process of collecting grouphash metadatagrouping.grouphashmetadata.backfill_needed
- tracks instances in which we'd backfill missing metadata, to help estimate the load that will create. As the accompanying comment says, this greatly overestimates the number of backfills we'd actually do (since we see the same grouphashes repeatedly, and each would only need to be backfilled once), but given that all we need is an upper bound in order to set our initial backfill sample rate, it's good enough for now.To test the first two metrics, they and their tag values have been added to the grouphash metadata snapshots. (The timer metric wasn't included because there's not much to test there, and the backfill metric wasn't included because it's temporary.)