getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.22k stars 4.21k forks source link

feat(autofix): Split out code mappings into a separate setup step #81083

Closed jennmueng closed 1 day ago

jennmueng commented 1 day ago

Renders the guided steps UI again, but this time the code mappings is its own step. To aid in reducing friction, there are now prominent buttons that jump to the relevant settings page: CleanShot 2024-11-20 at 14 30 45@2x CleanShot 2024-11-20 at 14 30 55@2x

The code mappings button will link directly to the code mappings setup page, but as there isn't really a straightforward way for me to easily test a github integration setup locally, I've added a fallback to just linking to the github integration setup page as usual if that query fails.

The configuration query is reverse engineered from: https://github.com/getsentry/sentry/blob/99f305eab1c7afdfbcf56db3ef9377b4cceb5e17/static/app/views/settings/organizationIntegrations/integrationDetailedView.tsx#L42-L66

trillville commented 1 day ago

this sparks joy

trillville commented 1 day ago

CleanShot 2024-11-20 at 14 51 21@2x should this copy be updated? Do you actually need to do what the text is saying or simply click the button (also do we need the hyperlink to the settings page in the text?)

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #81083 +/- ## ======================================= Coverage 78.48% 78.48% ======================================= Files 7215 7215 Lines 319793 319835 +42 Branches 44034 44048 +14 ======================================= + Hits 250996 251032 +36 - Misses 62404 62410 +6 Partials 6393 6393 ```