getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.22k stars 4.21k forks source link

ref(transactions): clean up post_process transactions areas #81091

Open JoshFerge opened 1 day ago

JoshFerge commented 1 day ago

after we deploy https://github.com/getsentry/sentry/pull/81085 and validate all is well, we can clean up the options used to deploy the feature, and delete code in post_process to do with transactions.

final step of https://github.com/getsentry/sentry/issues/81065

codecov[bot] commented 1 day ago

:x: 2 Tests Failed:

Tests completed Failed Passed Skipped
23108 2 23106 215
View the top 2 failed tests by shortest run time > > ```python > tests.sentry.tasks.test_store::test_store_consumer_type > ``` > >
Stack Traces | 2.48s run time > > > > > ```python > > #x1B[1m#x1B[.../sentry/tasks/test_store.py#x1B[0m:400: in test_store_consumer_type > > mock_transaction_processing_store.delete_by_key.assert_not_called() > > #x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6.../x64/lib/python3.12/unittest/mock.py#x1B[0m:908: in assert_not_called > > raise AssertionError(msg) > > #x1B[1m#x1B[31mE AssertionError: Expected 'delete_by_key' to not have been called. Called 1 times.#x1B[0m > > #x1B[1m#x1B[31mE Calls: [call('tx:3')].#x1B[0m > > ``` > >
tests.sentry.event_manager.test_event_manager.EventManagerTest::test_transaction_sampler_and_recieve_mock_called
Stack Traces | 4.33s run time > > ```python > #x1B[1m#x1B[.../sentry/event_manager/test_event_manager.py#x1B[0m:1665: in test_transaction_sampler_and_recieve_mock_called > assert mock_record_sample.mock_calls == [ > #x1B[1m#x1B[31mE AssertionError: assert [call(sender=...f0c0bee52e0>)] == [call(, 'wait')]#x1B[0m > #x1B[1m#x1B[31mE #x1B[0m > #x1B[1m#x1B[31mE At index 0 diff: call(sender=None, project=, event=) != call(, , 'wait')#x1B[0m > #x1B[1m#x1B[31mE #x1B[0m > #x1B[1m#x1B[31mE Full diff:#x1B[0m > #x1B[1m#x1B[31mE + [call(sender=None, project=, event=)]#x1B[0m > #x1B[1m#x1B[31mE - [#x1B[0m > #x1B[1m#x1B[31mE - call(, , 'wait'),#x1B[0m > #x1B[1m#x1B[31mE - ]#x1B[0m > ```

To view more test analytics, go to the Test Analytics Dashboard Got feedback? Let us know on Github