getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.22k stars 4.21k forks source link

feat(autofix): Write access is optional in check #81100

Closed jennmueng closed 1 hour ago

jennmueng commented 22 hours ago

Makes sure the frontend treats the githubWriteIntegration as optional and optionally passes checkWriteAccess to true

codecov[bot] commented 22 hours ago

:x: 2 Tests Failed:

Tests completed Failed Passed Skipped
8240 2 8238 0
View the top 2 failed tests by shortest run time > > ```python > AutofixSetupWriteAccessModal displays success text when installed repos for github app text > ``` > >
Stack Traces | 1.04s run time > > > > > ```python > > Error: Expected test not to call console.error(). > > > > If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs. > > > > > > > > Error: No mocked response found for request: GET .../1/autofix/setup/?check_write_access=true > > at Object. (.../events/autofix/autofixSetupWriteAccessModal.spec.tsx:82:48) > > at Promise.then.completed (.../jest-circus/build/utils.js:298:28) > > at new Promise () > > at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10) > > at _callCircusTest (.../jest-circus/build/run.js:316:40) > > at _runTest (.../jest-circus/build/run.js:252:3) > > at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9) > > at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9) > > at run (.../jest-circus/build/run.js:71:3) > > at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21) > > at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19) > > at runTestInternal (.../jest-runner/build/runTest.js:367:16) > > at runTest (.../jest-runner/build/runTest.js:444:34) > > at Object.worker (.../jest-runner/build/testWorker.js:106:12) > > at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25) > > at Object. (.../app/__mocks__/api.tsx:47:15) > > at Promise.then.completed (.../jest-circus/build/utils.js:298:28) > > at new Promise () > > at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10) > > at _callCircusHook (.../jest-circus/build/run.js:281:40) > > at _runTest (.../jest-circus/build/run.js:254:5) > > at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9) > > at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9) > > at run (.../jest-circus/build/run.js:71:3) > > at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21) > > at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19) > > at runTestInternal (.../jest-runner/build/runTest.js:367:16) > > at runTest (.../jest-runner/build/runTest.js:444:34) > > at Object.worker (.../jest-runner/build/testWorker.js:106:12) > > at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13) > > at Object. (.../node_modules/jest-fail-on-console/index.js:139:7) > > at Promise.then.completed (.../jest-circus/build/utils.js:298:28) > > at new Promise () > > at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10) > > at _callCircusHook (.../jest-circus/build/run.js:281:40) > > at _runTest (.../jest-circus/build/run.js:254:5) > > at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9) > > at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9) > > at run (.../jest-circus/build/run.js:71:3) > > at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21) > > at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19) > > at runTestInternal (.../jest-runner/build/runTest.js:367:16) > > at runTest (.../jest-runner/build/runTest.js:444:34) > > at Object.worker (.../jest-runner/build/testWorker.js:106:12) > > ``` > >
AutofixSetupWriteAccessModal displays help text when repos are not all installed
Stack Traces | 1.13s run time > > ```python > Error: Expected test not to call console.error(). > > If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs. > > > > Error: No mocked response found for request: GET .../1/autofix/setup/?check_write_access=true > at Object. (.../events/autofix/autofixSetupWriteAccessModal.spec.tsx:38:34) > at Promise.then.completed (.../jest-circus/build/utils.js:298:28) > at new Promise () > at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10) > at _callCircusTest (.../jest-circus/build/run.js:316:40) > at processTicksAndRejections (node:internal/process/task_queues:105:5) > at _runTest (.../jest-circus/build/run.js:252:3) > at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9) > at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9) > at run (.../jest-circus/build/run.js:71:3) > at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21) > at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19) > at runTestInternal (.../jest-runner/build/runTest.js:367:16) > at runTest (.../jest-runner/build/runTest.js:444:34) > at Object.worker (.../jest-runner/build/testWorker.js:106:12) > at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25) > at Object. (.../app/__mocks__/api.tsx:47:15) > at Promise.then.completed (.../jest-circus/build/utils.js:298:28) > at new Promise () > at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10) > at _callCircusHook (.../jest-circus/build/run.js:281:40) > at _runTest (.../jest-circus/build/run.js:254:5) > at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9) > at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9) > at run (.../jest-circus/build/run.js:71:3) > at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21) > at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19) > at runTestInternal (.../jest-runner/build/runTest.js:367:16) > at runTest (.../jest-runner/build/runTest.js:444:34) > at Object.worker (.../jest-runner/build/testWorker.js:106:12) > at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13) > at Object. (.../node_modules/jest-fail-on-console/index.js:139:7) > at Promise.then.completed (.../jest-circus/build/utils.js:298:28) > at new Promise () > at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10) > at _callCircusHook (.../jest-circus/build/run.js:281:40) > at _runTest (.../jest-circus/build/run.js:254:5) > at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9) > at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9) > at run (.../jest-circus/build/run.js:71:3) > at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21) > at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19) > at runTestInternal (.../jest-runner/build/runTest.js:367:16) > at runTest (.../jest-runner/build/runTest.js:444:34) > at Object.worker (.../jest-runner/build/testWorker.js:106:12) > ```

To view more test analytics, go to the Test Analytics Dashboard Got feedback? Let us know on Github

codecov[bot] commented 4 hours ago

Bundle Report

Changes will increase total bundle size by 820 bytes (0.0%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes | Bundle name | Size | Change | | ----------- | ---- | ------ | | app-webpack-bundle-array-push | 31.98MB | 820 bytes (0.0%) :arrow_up: |