getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.22k stars 4.21k forks source link

chore(similarity): Add logging for over 30 system frames #81130

Open jangjodi opened 6 hours ago

jangjodi commented 6 hours ago

Add logging for events with stacktraces with over 30 system-only frames

jangjodi commented 6 hours ago

if we follow the pattern where we raise the exception we can catch and log then, so no need to pass anything extra into the function

if we raise the exception, would we still be able to return the stacktrace string? I chose to do it this way so the grouping logic would not change yet

codecov[bot] commented 1 hour ago

:x: 877 Tests Failed:

Tests completed Failed Passed Skipped
23119 877 22242 215
View the top 3 failed tests by shortest run time > > ```python > tests.sentry.hybridcloud.services.test_control_organization_provisioning.TestControlOrganizationProvisioningSlugUpdates__InControlMode::test_swap_for_org_without_primary_slug > ``` > >
Stack Traces | 0.005s run time > > > > > ```python > > No failure message available > > ``` > >
tests.sentry.hybridcloud.services.test_control_organization_provisioning.TestControlOrganizationProvisioningSlugUpdates__InControlMode::test_swap_with_same_slug
Stack Traces | 0.005s run time > > ```python > No failure message available > ```
tests.sentry.sentry_apps.test_sentry_app_creator.TestCreator::test_creates_proxy_user
Stack Traces | 0.006s run time > > ```python > No failure message available > ```

To view more test analytics, go to the Test Analytics Dashboard Got feedback? Let us know on Github