getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.22k stars 4.21k forks source link

chore(metrics-summaries): Remove metrics summaries queries and endpoints #81133

Open phacops opened 7 hours ago

phacops commented 7 hours ago

The metrics summaries are not needed anymore since we shut down DDM.

This will remove the query layer and endpoints used by the frontend to list samples associated with metrics.

https://github.com/getsentry/team-ingest/issues/544

sentry-io[bot] commented 7 hours ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/utils/snuba.py

Function Unhandled Issue
_apply_cache_and_build_results RateLimitExceeded: Query on could not be run due to allocation policies, info: {'details': {'ConcurrentRateLimitAllo... ...
Event Count: 11
_apply_cache_and_build_results RateLimitExceeded: Query on could not be run due to allocation policies, info: {'details': {'BytesScannedRejectingPo... ...
Event Count: 7

Did you find this useful? React with a 👍 or 👎

codecov[bot] commented 6 hours ago

:x: 7 Tests Failed:

Tests completed Failed Passed Skipped
23100 7 23093 215
View the top 3 failed tests by shortest run time > > ```python > tests.sentry.api.endpoints.test_organization_metrics.OrganizationMetricsPermissionTest::test_access_with_wrong_permission_scopes > ``` > >
Stack Traces | 4.02s run time > > > > > ```python > > #x1B[1m#x1B[.../api/endpoints/test_organization_metrics.py#x1B[0m:93: in test_access_with_wrong_permission_scopes > > response = self.send_request(self.organization, token, method, endpoint, *rest) > > #x1B[1m#x1B[.../api/endpoints/test_organization_metrics.py#x1B[0m:83: in send_request > > url = reverse(endpoint, args=(organization.slug,) + args) > > #x1B[1m#x1B[31m.venv/lib/python3.12.../django/urls/base.py#x1B[0m:88: in reverse > > return resolver._reverse_with_prefix(view, prefix, *args, **kwargs) > > #x1B[1m#x1B[31m.venv/lib/python3.12.../django/urls/resolvers.py#x1B[0m:831: in _reverse_with_prefix > > raise NoReverseMatch(msg) > > #x1B[1m#x1B[31mE django.urls.exceptions.NoReverseMatch: Reverse for 'sentry-api-0-organization-metrics-samples' not found. 'sentry-api-0-organization-metrics-samples' is not a valid view function or pattern name.#x1B[0m > > ``` > >
tests.sentry.api.endpoints.test_organization_metrics.OrganizationMetricsPermissionTest::test_access_of_another_organization
Stack Traces | 6.29s run time > > ```python > #x1B[1m#x1B[.../api/endpoints/test_organization_metrics.py#x1B[0m:104: in test_access_of_another_organization > response = self.send_request(self.organization, token, method, endpoint, *rest) > #x1B[1m#x1B[.../api/endpoints/test_organization_metrics.py#x1B[0m:83: in send_request > url = reverse(endpoint, args=(organization.slug,) + args) > #x1B[1m#x1B[31m.venv/lib/python3.12.../django/urls/base.py#x1B[0m:88: in reverse > return resolver._reverse_with_prefix(view, prefix, *args, **kwargs) > #x1B[1m#x1B[31m.venv/lib/python3.12.../django/urls/resolvers.py#x1B[0m:831: in _reverse_with_prefix > raise NoReverseMatch(msg) > #x1B[1m#x1B[31mE django.urls.exceptions.NoReverseMatch: Reverse for 'sentry-api-0-organization-metrics-samples' not found. 'sentry-api-0-organization-metrics-samples' is not a valid view function or pattern name.#x1B[0m > ```
tests.sentry.api.endpoints.test_organization_metrics.OrganizationMetricsPermissionTest::test_access_with_permissions
Stack Traces | 7s run time > > ```python > #x1B[1m#x1B[.../api/endpoints/test_organization_metrics.py#x1B[0m:112: in test_access_with_permissions > response = self.send_request(self.organization, token, method, endpoint, *rest) > #x1B[1m#x1B[.../api/endpoints/test_organization_metrics.py#x1B[0m:83: in send_request > url = reverse(endpoint, args=(organization.slug,) + args) > #x1B[1m#x1B[31m.venv/lib/python3.12.../django/urls/base.py#x1B[0m:88: in reverse > return resolver._reverse_with_prefix(view, prefix, *args, **kwargs) > #x1B[1m#x1B[31m.venv/lib/python3.12.../django/urls/resolvers.py#x1B[0m:831: in _reverse_with_prefix > raise NoReverseMatch(msg) > #x1B[1m#x1B[31mE django.urls.exceptions.NoReverseMatch: Reverse for 'sentry-api-0-organization-metrics-samples' not found. 'sentry-api-0-organization-metrics-samples' is not a valid view function or pattern name.#x1B[0m > ```

To view more test analytics, go to the Test Analytics Dashboard Got feedback? Let us know on Github