getsentry / sentry

Developer-first error tracking and performance monitoring
https://sentry.io
Other
39.23k stars 4.21k forks source link

feat(trace) issues only collapse trace #81171

Open JonasBa opened 8 hours ago

JonasBa commented 8 hours ago

We bfs to find collapsed nodes, because we want to preserve the tree structure, this means that it is possible to have consecutive collapsed nodes at different levels in the tree. We can fix this by doing a second pass over the list of the nodes in the tree and collapse any siblings. I also removed the condition to not render the errors only trace view as this seems to be a case that we handle in our new design.

codecov[bot] commented 8 hours ago

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ce/newTraceDetails/traceModels/issuesTraceTree.tsx 93.33% 1 Missing :warning:
...nce/newTraceDetails/traceRow/traceCollapsedRow.tsx 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## jb/issues/trace-view #81171 +/- ## ===================================================== Coverage 78.35% 78.35% ===================================================== Files 7221 7221 Lines 317711 317727 +16 Branches 43833 43838 +5 ===================================================== + Hits 248931 248947 +16 Misses 62450 62450 Partials 6330 6330 ```