getsentry / spotlight

Your Universal Debug Toolbar
https://spotlightjs.com
Other
377 stars 11 forks source link

feat(spotlight): Add self-contained spotlight binary creation #559

Closed BYK closed 1 day ago

BYK commented 2 weeks ago

This PR adds a new release type which is a self-contained CLI akin to running npx @spotlightjs/spotlight but without any node or npx or any other requirements on the system.

It also changes how we serve the static assets: instead of serving the entire folder, which can be dangerous as it allows access to arbitrary files, we now use the manifest.json generated when compiling it and only serve files listed there, directly from memory. This should also increase the performance.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 10:52am
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 31.15%. Comparing base (ea666ac) to head (3a5ec6c). Report is 135 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #559 +/- ## ========================================== + Coverage 29.00% 31.15% +2.14% ========================================== Files 60 83 +23 Lines 4144 5030 +886 Branches 72 99 +27 ========================================== + Hits 1202 1567 +365 - Misses 2942 3463 +521 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

Shubhdeep12 commented 6 days ago

working fine in linux 🚀

BYK commented 5 days ago

@Lms24 thanks for the review! Updated the PR desc and responded to your question.