Closed loewenheim closed 11 months ago
Merging #803 (e78fdf6) into master (09c291b) will decrease coverage by
0.23%
. The diff coverage is95.23%
.:exclamation: Current head e78fdf6 differs from pull request most recent head 3f90cb3. Consider uploading reports for the commit 3f90cb3 to get more accurate results
The implementation has been simplified and the serde
functionality removed.
In preparation of using sourcelinks in sourcebundles, this extracts the sourcelink functionality from
symbolic-ppdb
and moves it tosymbolic-common
. It also refactors the implementation based onserde
.The JSON representation of a
SourceLinkMappings
struct looks like this:One downside of this is that it makes the
serde
dependency ofsymbolic-common
non-optional. I don't know how big a deal this really is, but it may be that this code might more appropriately live in a different place.