search

getsentry / symbolic

Stack trace symbolication library written in Rust
https://github.com/getsentry/symbolic#readme
MIT License
436 stars 75 forks source link

fix empty parameters list issue #821

Closed viglia closed 7 months ago

viglia commented 7 months ago

Use a specific boolean flag to decide whether to deobfuscate based on parameters list or line numbers.

Empty parameters list should not be used to make this discrimination, but at the same Time Option<T> type is not FFI safe therefore we cannot use it for the Rust bindings.

codecov[bot] commented 7 months ago

Codecov Report

Merging #821 (73dd848) into master (954e533) will increase coverage by 0.08%. The diff coverage is 0.00%.

:exclamation: Current head 73dd848 differs from pull request most recent head d0f82f0. Consider uploading reports for the commit d0f82f0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #821 +/- ## ========================================== + Coverage 74.73% 74.81% +0.08% ========================================== Files 63 63 Lines 15700 15678 -22 ========================================== - Hits 11733 11730 -3 + Misses 3967 3948 -19 ```