search

getsentry / symbolic

Stack trace symbolication library written in Rust
https://github.com/getsentry/symbolic#readme
MIT License
447 stars 75 forks source link

Support for DWARFv5 embedded source code extension #849

Closed Mrmaxmeier closed 2 months ago

Mrmaxmeier commented 3 months ago

Hi,

this implements support for source code embedded directly inside of the DWARF debug info. (Fixes #835)

I'm not sure about the logic in source_by_path though. Should it only match full paths or relative paths instead? My use-case is fine with either way since I'm iterating over the files in the debug session directly.

This PR currently depends on support in gimli that has not made it into a release yet. I'll update the PR once a new version of gimli is available on crates.io.

Thanks!

loewenheim commented 14 hours ago

@Mrmaxmeier I'm sorry, we'll have to revert this. The check for whether a file has sources is inordinately expensive in terms of memory and is causing issues in our infrastructure.

Mrmaxmeier commented 13 hours ago

Welp, sorry about that :melting_face:

loewenheim commented 13 hours ago

Not at all, thank you for the contribution. Sorry we can't support it at the time :/