getsentry / symbolicator

Native Symbolication as a Service

https://getsentry.github.io/symbolicator/

MIT License

359 stars 48 forks source link

Capture minidump modules with usable code-id #1298

Closed Swatinem closed 1 year ago

Swatinem commented 1 year ago

We were previously discarding all minidump modules that did not have a debug-id. However you can still at least get a reasonable function name in most cases from the symbol table of a code file using the code-id.

skip-changelog

codecov[bot] commented 1 year ago

Codecov Report

Merging #1298 (e9ce867) into master (b2c603f) will decrease coverage by 0.58%. Report is 1 commits behind head on master. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1298      +/-   ##
==========================================
- Coverage   76.46%   75.88%   -0.58%     
==========================================
  Files          88       91       +3     
  Lines       14462    14574     +112     
==========================================
+ Hits        11058    11060       +2     
- Misses       3404     3514     +110