getsentry / symbolicator

Native Symbolication as a Service
https://getsentry.github.io/symbolicator/
MIT License
352 stars 45 forks source link

Do not persist SourceMap contents in `FileInBundleCache` #1359

Closed Swatinem closed 4 months ago

Swatinem commented 4 months ago

According to metrics, the cache is quite effective in ST and on LPQ instances. Less so in production, most likely because the cache is too small.

To increase the effective size of the cache, we do not store the actual sourcemap contents in it anymore. These contents are only used for sourcemapcache generation, and are not usually required.

skip-changelog

codecov[bot] commented 4 months ago

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (6613a10) 75.99% compared to head (3498cec) 75.75%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1359 +/- ## ========================================== - Coverage 75.99% 75.75% -0.25% ========================================== Files 100 101 +1 Lines 14835 14946 +111 ========================================== + Hits 11274 11322 +48 - Misses 3561 3624 +63 ```