search

getsentry / symbolicator

Native Symbolication as a Service
https://getsentry.github.io/symbolicator/
MIT License
352 stars 45 forks source link

doc(sources): Document rationale for Sentry list_file behavior #1372

Closed loewenheim closed 4 months ago

loewenheim commented 4 months ago

The debug files endpoint in Sentry supports querying by a list of file formats: https://github.com/getsentry/sentry/blob/e23668f702957cc09d47977cacfa2b9c8b384928/src/sentry/api/endpoints/debug_files.py#L248

https://github.com/getsentry/sentry/blob/e23668f702957cc09d47977cacfa2b9c8b384928/src/sentry/api/endpoints/debug_files.py#L281-L287

Therefore we can already do the filtering by file type when we make the query to the Sentry source, instead of getting all files and filtering afterwards.

loewenheim commented 4 months ago

I've changed the PR to instead add a note about why it works the way it does.