getsentry / symbolicator

Native Symbolication as a Service
https://getsentry.github.io/symbolicator/
MIT License
352 stars 45 forks source link

feat(proguard): add signature support and remove parameters from JvmFrame #1421

Closed viglia closed 3 months ago

viglia commented 3 months ago

The parameters list will be computed from the signature passed. The signature itself will be deobfuscated.

This, at the moment, assumes that the signature passed is always a JDI Type Signatures, which is always the case for the profiling use case. If we ever predict to use this (param mapping deobfuscation) in scenarios where we might receive a signature in normal form (with Java types), we'll have to add some further support to detect the kind of signature and apply the proper signature parsing.

viglia commented 3 months ago

@Swatinem thanks for the feedback!

I'm closing this PR as I'm moving this over to rust-proguard here