getsentry / symbolicator

Native Symbolication as a Service
https://getsentry.github.io/symbolicator/
MIT License
358 stars 47 forks source link

Can't find pdbs bundled in nupkg #1437

Open bruno-garcia opened 5 months ago

bruno-garcia commented 5 months ago

Missing symbols in the event: image

But I can confirm the pdbs exist on nuget.org, but they are no in the snupkg but in the actual nupkg next to the DLL. image

IDEs are able to pull from both, but seems symbolicator only pulls from the snupkg.

bruno-garcia commented 5 months ago

Link to example event: https://sentry.sentry.io/issues/4474793733/?project=1886021&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&statsPeriod=24h&stream_index=1

Also to help clarify impact: .NET profiling only works if symbols can be loaded otherwise it'll show unknown on function names

loewenheim commented 5 months ago

Here is log output of Symbolicator trying to download the GCS pdb:

2024-04-17T15:21:07.275945Z DEBUG symbolicator_service::download::http: Fetching debug file from `https://symbols.nuget.org/download/symbols/Google.Cloud.Storage.V1.pdb/A18B94CDA70745BEB0A2C316C2AB5314ffffffff/Google.Cloud.Storage.V1.pdb`
[…]
2024-04-17T15:21:07.413918Z DEBUG symbolicator_service::download: Unexpected client error status code from `https://symbols.nuget.org/download/symbols/Google.Cloud.Storage.V1.pdb/A18B94CDA70745BEB0A2C316C2AB5314ffffffff/Google.Cloud.Storage.V1.pdb`: 404 Not Found

It's trying to download from that URL with an additional header of SymbolChecksum: SHA256:cd948ba107a7be65b0a2c316c2ab5314f8339cb1c32051c3138287f307a274d6. Assuming the identifiers and the checksum are all correct, where on the server should the file be found? How does snupkg vs nupkg translate into paths?

bruno-garcia commented 5 months ago

How does snupkg vs nupkg translate into paths?

I actually don't know. But I'll ask here: https://github.com/NuGet/NuGetGallery/issues/9925

loewenheim commented 4 months ago

Blocked on https://github.com/NuGet/NuGetGallery/issues/9925.