Add support for watchOS symbols with different naming scheme

getsentry / symsynd

BSD 3-Clause "New" or "Revised" License

25 stars 9 forks source link

Add support for watchOS symbols with different naming scheme #10

Closed HazAT closed 7 years ago

HazAT commented 7 years ago

Ready to review

mitsuhiko commented 7 years ago

Looks good but I think we will need to store the "Watch2,3" information somewhere.

HazAT commented 7 years ago

Ahh I see ... didn't check if this gets stored -> added

'watch_hardware_major': int(tup[0]),
'watch_hardware_minor': int(tup[1]),

mitsuhiko commented 7 years ago

I would propose we store it as "sdk_identifier" with a value of "Watch2,3" or something like that. Reason being that I can imagine this same thing coming up in the future as well with other platforms. And we just leave it at null when it's not set.