feat: Add initial symx ota cli interface

getsentry / symx

Apple symbol manager

MIT License

4 stars 0 forks source link

feat: Add initial symx ota cli interface #6

Closed ashwoods closed 1 year ago

supervacuus commented 1 year ago

This is an incredibly difficult-to-review PR, given that you said mostly cosmetic. I have no idea what happened besides the addition of a CLI interface:

Ten files have changed,
you changed quite a bit on the main branch before that PR, so now I have no idea how that differed from my previous state
This is especially relevant since you moved contents into new files, so I have no sensible diff
what does poetry do? Do I have to use it? Do I have to install something? Does it conflict with requirements.txt?
same with the stuff in pyproject.toml?

supervacuus commented 1 year ago

As discussed yesterday, I reluctantly accept :-) as in:

enabling build/dep/venv setup w/o requirements.txt and setup.py is the right direction, but a bit of a distraction right now given the state of the project/repo and deliberately choosing poetry vs. whatever is not something I want to invest time right now... so if it bugs me... I'll drop it.
the same applies to introducing Typer
please separate future PRs to allow for quicker review, thx!