search

getsentry / team-mobile

Meta issues for the Mobile team
4 stars 1 forks source link

Network request metrics #104

Open idosun opened 1 year ago

idosun commented 1 year ago

Problem Statement

We would like to track endpoints that our apps (mobile / web) make requests to and track various metrics like success rates, response, times, payload size, etc.

Solution Brainstorm

No response

┆Issue is synchronized with this Jira Improvement by Unito

getsantry[bot] commented 1 year ago

Assigning to @getsentry/support for routing, due by (sfo). ⏲️

getsantry[bot] commented 1 year ago

Routing to @getsentry/team-mobile for triage, due by (sfo). ⏲️

marandaneto commented 1 year ago

@kahest should this be moved to team-mobile? adding labels for each platform, etc.

kahest commented 1 year ago

@marandaneto yes, makes sense, I'll do it

markushi commented 1 year ago

Some quick thoughts:

@kahest This should definitely discussed from a product perspective as well.

kylannjohnson commented 1 year ago

We would love to see requests (or really any child span) be visible in Discover and dashboards. For requests, we would be most interested in Error Rate (or success rate) which we would just refer to as Availability. We'd also calculate a percentile array based on the total processing time of the request, but I'd be interested to know the breakdown of Client side processing (i.e. moshi/GSON deserialization), in-transit time, and server time.

marandaneto commented 1 year ago

We would love to see requests (or really any child span) be visible in Discover and dashboards. For requests, we would be most interested in Error Rate (or success rate) which we would just refer to as Availability. We'd also calculate a percentile array based on the total processing time of the request, but I'd be interested to know the breakdown of Client side processing (i.e. moshi/GSON deserialization), in-transit time, and server time.

Something like this would already help https://github.com/getsentry/sentry-java/pull/2158 at least related to network stats.

marandaneto commented 1 year ago

Lets just add platform labels once there's a spec of what SDKs have to do and they are actionable, as of now it stays with the Mobile plat label + product.

philipphofmann commented 1 year ago

I think the SDKs already send enough data. We have SDK spans. The product could already pull the data and provide such statistics, or am I missing something, @marandaneto?

marandaneto commented 1 year ago

@philipphofmann I agree but that depends on the performance product, also spans are not indexed, so it's not possible to extract those metrics AFAIK, unless this has changed.

kahest commented 1 year ago

related: https://github.com/getsentry/team-mobile/issues/134

Putting this back on the shelf for now - this might be superseded by other initiatives that enable span level metrics