getsentry / team-mobile

Meta issues for the Mobile team
4 stars 1 forks source link

`http.response.status_code` normalization for Metrics & Alerts #121

Closed kahest closed 1 year ago

kahest commented 1 year ago

Background:

http.status is set in different places in different SDKs which creates some problems in processing for metrics extraction and then

https://www.notion.so/sentry/Expand-Metrics-for-Alerts-cdfa32d7624e498b8246c3f131f753f1#17480955e2fb4407b619b9236bc2723a

Requirements:

Note: .NET and Java are handled in https://github.com/getsentry/team-sdks/issues/9.

### Validate Per SDK and check as is
- [ ] https://github.com/getsentry/sentry-cocoa/issues/3076
- [ ] https://github.com/getsentry/sentry-dart/issues/1473
- [x] https://github.com/getsentry/sentry-java/pull/2786
- [x] React Native
romtsn commented 1 year ago

We'll look into the code base and check if anything has to be done and check off the platform if nothing is needed.

marandaneto commented 1 year ago

@antonpirker this doc is related to this issue right? We just need to be sure what the schema is, so we can double-check in our implementation.

marandaneto commented 1 year ago

https://develop.sentry.dev/sdk/performance/span-operations/ does not tell where http.status should go. https://github.com/getsentry/rfcs/pull/89 is a draft and it links to OTel which is a huge breaking change.

marandaneto commented 1 year ago

https://github.com/getsentry/develop/pull/940 is the spec, I believe SDKs don't set that yet, so we have to.

antonpirker commented 1 year ago

@antonpirker this doc is related to this issue right? We just need to be sure what the schema is, so we can double-check in our implementation.

Maybe too late, but for the record: Yes. this doc is "where are all the SDKs storing the http status code right now". In the future we want all the SDKs store the http status code in the same place, making it easier of ingest to act on it.

marandaneto commented 1 year ago

It changed to http.response.status_code https://develop.sentry.dev/sdk/performance/span-data-conventions/

krystofwoldrich commented 1 year ago

React Native SDK doesn't set status_code. If there will be any changes RN gets it from JS SDK.