Closed romtsn closed 1 year ago
Cocoa don't have lastEventId. Is this something we should have?
we set it for captureEvent
captureException
captureMessage
, I guess thats where we could add it, if not yet
RN was missing the function. It was accessible only indirectly thru the hub. I'm waiting for a new JS release to test the feature. But we don't change the JS logic and that one is correct.
we set it for captureEvent captureException captureMessage, I guess thats where we could add it, if not yet
@philipphofmann @brustolin Do we need this?
RN was missing the function. It was accessible only indirectly thru the hub. I'm waiting for a new JS release to test the feature. But we don't change the JS logic and that one is correct.
@krystofwoldrich Have you been able to test this?
@philipphofmann @brustolin Do we need this?
We probably do.
@kahest Yes, it works correctly, ot doesn't set the id for transactions.
@philipphofmann @brustolin Do we need this?
We probably do.
Created https://github.com/getsentry/sentry-cocoa/issues/2705 for discussion.
Closing this issue since everything is done. 👍
lastEventId
could be used for reporting a userfeedback, so we cant assign the lastEventId for transactionsSpec: https://develop.sentry.dev/sdk/performance/#hub-changes
See https://github.com/getsentry/develop/issues/431 for more details