getsentry / team-mobile

Meta issues for the Mobile team
4 stars 1 forks source link

Don't set `lastEventId` for transactions #61

Closed romtsn closed 1 year ago

romtsn commented 2 years ago

lastEventId could be used for reporting a userfeedback, so we cant assign the lastEventId for transactions

Spec: https://develop.sentry.dev/sdk/performance/#hub-changes

See https://github.com/getsentry/develop/issues/431 for more details

brustolin commented 2 years ago

Cocoa don't have lastEventId. Is this something we should have?

romtsn commented 2 years ago

we set it for captureEvent captureException captureMessage, I guess thats where we could add it, if not yet

krystofwoldrich commented 1 year ago

RN was missing the function. It was accessible only indirectly thru the hub. I'm waiting for a new JS release to test the feature. But we don't change the JS logic and that one is correct.

kahest commented 1 year ago

we set it for captureEvent captureException captureMessage, I guess thats where we could add it, if not yet

@philipphofmann @brustolin Do we need this?

kahest commented 1 year ago

RN was missing the function. It was accessible only indirectly thru the hub. I'm waiting for a new JS release to test the feature. But we don't change the JS logic and that one is correct.

@krystofwoldrich Have you been able to test this?

brustolin commented 1 year ago

@philipphofmann @brustolin Do we need this?

We probably do.

krystofwoldrich commented 1 year ago

@kahest Yes, it works correctly, ot doesn't set the id for transactions.

kahest commented 1 year ago

@philipphofmann @brustolin Do we need this?

We probably do.

Created https://github.com/getsentry/sentry-cocoa/issues/2705 for discussion.

Closing this issue since everything is done. 👍