search

getsentry / team-mobile

Meta issues for the Mobile team
4 stars 1 forks source link

Support `beforeSendTransaction` #72

Closed marandaneto closed 1 year ago

marandaneto commented 2 years ago

https://github.com/getsentry/sentry-docs/pull/5814

RN and Capacitor get for free from JS SDK. Unity gets it for free from .NET SDK. iOS SDK has to fix this bug.

### Tasks
- [X] https://github.com/getsentry/sentry-java/issues/2358
- [ ] https://github.com/getsentry/sentry-dart/issues/1151
- [ ] https://github.com/getsentry/sentry-dotnet/issues/2077
- [x] iOS
- [X] [RN](https://github.com/getsentry/sentry-react-native/issues/2680) has it from JS
- [X] Capacitor has it from JS
marandaneto commented 1 year ago

RN and Capacitor get it for free from JS SDK. RN has to patch the beforeSendTransaction to swallow exceptions and not crash the app in case there are problems similar to other callbacks, I will raise a new issue for that.

kahest commented 1 year ago

As discussed, iOS tx already go through beforeSend. For IOS we want to wait for the ongoing RFC to decide how to implement this.